morrySnow commented on code in PR #15243:
URL: https://github.com/apache/doris/pull/15243#discussion_r1057061380
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/ResolveOrdinalInOrderByAndGroupBy.java:
##########
@@ -74,11 +72,6 @@ public List<Rule> buildRules() {
IntegerLikeLiteral i =
(IntegerLikeLiteral) groupByExpr;
int ord = i.getIntValue();
Expression aggExpr = aggOutput.get(ord -
1);
- if
(!CollectionUtils.isEmpty(aggExpr.children())
- && aggExpr.child(0) instanceof
Literal) {
- continue;
- }
- checkOrd(ord, aggOutput.size());
Review Comment:
why remove these codes in this PR?
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/EliminateGroupByConstant.java:
##########
@@ -50,12 +50,18 @@ public Rule build() {
List<Expression> groupByExprs = aggregate.getGroupByExpressions();
List<NamedExpression> outputExprs =
aggregate.getOutputExpressions();
Set<Expression> slotGroupByExprs = Sets.newLinkedHashSet();
+ Expression lit = null;
for (Expression expression : groupByExprs) {
expression = FoldConstantRule.INSTANCE.rewrite(expression);
if (!(expression instanceof Literal)) {
slotGroupByExprs.add(expression);
+ } else {
+ lit = expression;
}
}
+ if (slotGroupByExprs.isEmpty() && lit != null) {
+ slotGroupByExprs.add(lit);
+ }
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
