github-actions[bot] commented on code in PR #15353:
URL: https://github.com/apache/doris/pull/15353#discussion_r1057042857
##########
be/src/vec/olap/vertical_merge_iterator.h:
##########
@@ -231,6 +241,11 @@
Status next_batch(Block* block) override;
const Schema& schema() const override { return *_schema; }
uint64_t merged_rows() const override { return _merged_rows; }
+ Status current_block_row_locations(std::vector<RowLocation>*
block_row_locations) {
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final'
[modernize-use-override]
```suggestion
Status current_block_row_locations(std::vector<RowLocation>*
block_row_locations) override {
```
##########
be/src/vec/olap/vertical_merge_iterator.h:
##########
@@ -231,6 +241,11 @@ class VerticalHeapMergeIterator : public RowwiseIterator {
Status next_batch(Block* block) override;
const Schema& schema() const override { return *_schema; }
uint64_t merged_rows() const override { return _merged_rows; }
+ Status current_block_row_locations(std::vector<RowLocation>*
block_row_locations) {
Review Comment:
warning: 'current_block_row_locations' overrides a member function but is
not marked 'override' [clang-diagnostic-inconsistent-missing-override]
```cpp
Status current_block_row_locations(std::vector<RowLocation>*
block_row_locations) {
^
```
**be/src/olap/iterators.h:141:** overridden virtual function is here
```cpp
virtual Status current_block_row_locations(std::vector<RowLocation>*
block_row_locations) {
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
