github-actions[bot] commented on code in PR #63474:
URL: https://github.com/apache/doris/pull/63474#discussion_r3347318238
##########
run-be-ut.sh:
##########
@@ -260,6 +287,31 @@ else
BUILD_TYPE="${CMAKE_BUILD_TYPE}"
fi
+OPENMP_CMAKE_VARS=()
+if [[ "$(uname -s)" == 'Darwin' ]]; then
+ OPENMP_CMAKE_VARS=(
+ # ANN (faiss/openblas) has libc++ compatibility issues with llvm@20 on
macOS.
+ # Disable it for local UT builds; CI runs on Linux where it compiles
fine.
+ "-DDISABLE_ANN=ON"
+ # Clang@18 does not support capturing structured bindings in OpenMP
parallel
+ # regions (variant_util.cpp uses this pattern). Disable OpenMP for
macOS local
+ # UT builds: #pragma omp directives become no-ops, which is fine for
testing.
+ "-DOpenMP_C_FLAGS="
+ "-DOpenMP_CXX_FLAGS="
+ "-DOpenMP_C_LIB_NAMES=none"
+ "-DOpenMP_CXX_LIB_NAMES=none"
+ "-DCMAKE_DISABLE_FIND_PACKAGE_OpenMP=ON"
+ # Apple's clang requires an explicit sysroot to find standard C headers
+ # (stdio.h etc.) in third-party C code (clucene, vp4d.c, …).
+ "-DCMAKE_OSX_SYSROOT=$(xcrun --show-sdk-path)"
+ # Apple's ar/ranlib use a 32-bit archive offset table that overflows
when
+ # ASAN-instrumented .o files exceed ~4 GB total. Use LLVM's ar/ranlib
+ # (from Homebrew llvm@18) which supports the GNU 64-bit extended
format.
+ "-DCMAKE_AR=/opt/homebrew/opt/llvm@18/bin/llvm-ar"
+ "-DCMAKE_RANLIB=/opt/homebrew/opt/llvm@18/bin/llvm-ranlib"
Review Comment:
This hardcodes `llvm@18`, but the updated macOS workflow installs only
`llvm@16` (`.github/workflows/be-ut-mac.yml`). On a clean `macos-15` runner
`/opt/homebrew/opt/llvm@18/bin/llvm-ar` and `llvm-ranlib` are not guaranteed to
exist, so CMake/build can fail before any UT runs. Please keep the installed
Homebrew LLVM version and these tool paths consistent, or discover
`llvm-ar`/`llvm-ranlib` from an installed toolchain instead of hardcoding an
uninstalled version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
