github-actions[bot] commented on code in PR #63809:
URL: https://github.com/apache/doris/pull/63809#discussion_r3333036116
##########
fe/fe-core/src/main/java/org/apache/doris/tablefunction/MetadataGenerator.java:
##########
@@ -1828,6 +1828,7 @@ private static TFetchSchemaTableDataResult
metaCacheStatsMetadataResult(TSchemaT
trow.addToColumnValue(new TCell().setDoubleVal(
entryStats.getAverageLoadPenaltyNanos() /
TimeUnit.MILLISECONDS.toNanos(1)));
trow.addToColumnValue(new
TCell().setLongVal(entryStats.getEvictionCount())); // EVICTION_COUNT
+ trow.addToColumnValue(new
TCell().setDoubleVal(entryStats.getEvictionRate())); // EVICTION_RATE
Review Comment:
Adding this value unconditionally makes `CATALOG_META_CACHE_STATISTICS` fail
across mixed FE/BE versions. The BE scanner sends its `_s_tbls_columns` in
`columns_name` and then rejects any FE response whose
`TRow.column_value.size()` differs from its local column count. During rolling
upgrade, an old BE querying a new FE will expect the old column count but
receive this extra cell; a new BE querying an old FE will expect this cell but
receive one fewer. Please make this schema-table path honor the requested
column list (or otherwise tolerate missing/extra columns) before adding the new
column, and cover the old/new count mismatch with a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
