Mryange opened a new pull request, #63937:
URL: https://github.com/apache/doris/pull/63937
### What problem does this PR solve?
Problem Summary:
HeapSorter kept a `have_runtime_predicate` flag and skipped its local TopN
filtering path whenever the sort node had a runtime predicate. The heap sorter
should no longer branch on whether a runtime predicate exists. This PR removes
that constructor argument and member state, and always uses the existing heap
filter path once the heap queue is valid and has reached the heap size.
The sort sink no longer queries `QueryContext::has_runtime_predicate()` when
constructing `HeapSorter`. The heap sorter unit test is also updated so it
checks the expected top value directly instead of reading it from an input
block that may be modified by the filtering path.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
