wenzhenghu opened a new pull request, #63919:
URL: https://github.com/apache/doris/pull/63919
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Normal internal-table inserts currently treat publish timeout as a committed
insert and return success with COMMITTED status. This behavior is acceptable
when clients only care that the transaction has been committed and can tolerate
delayed visibility, but it is unsafe for pipelines whose downstream steps
depend on the inserted data already being visible.
A typical case is ETL workflows that first use CREATE TABLE AS SELECT to
build a temporary table and then immediately read that table to populate a
downstream result table. If the upstream transaction has been committed but is
not yet VISIBLE, the downstream step may temporarily read no rows and silently
write empty data into the final table, so the whole pipeline appears successful
even though the result is incorrect.
Doris already returns an error in explicit transaction mode when a COMMIT
statement times out before the transaction becomes visible. This change adds a
compatible mode for the regular non-transactional internal-table insert path by
introducing a session variable, insert_visible_timeout_return_mode, so users
can choose whether publish timeout should keep returning COMMITTED or return
ERR.
The implementation also keeps committed-side bookkeeping unchanged in error
mode so finished load jobs, insert result metadata, and related accounting
still reflect the real transaction state.
### Release note
Add a session variable to control whether normal internal-table inserts
return COMMITTED or ERR when publish visibility times out.
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
