mrhhsg commented on code in PR #63517:
URL: https://github.com/apache/doris/pull/63517#discussion_r3323838482
##########
be/src/util/jsonb_document.h:
##########
@@ -363,19 +418,51 @@ struct leg_info {
Review Comment:
Thanks, fixed in `2cb8f4c0b24`. `has_escapes` is now reset at the start of
each parsed path leg, so a following unescaped member no longer calls
`remove_escapes()` and overwrites the next delimiter. I also added
`jsonb_path_escaped_member_round_trips_with_following_legs` to cover
`$."a\\nb".c.d`-style nested round trip with trailing legs.
Validation:
- `build-support/clang-format.sh`; `build-support/check-format.sh`; `git
diff --check`
- `DORIS_HOME=$PWD ninja -C be/ut_build_ASAN
test/CMakeFiles/doris_be_test.dir/core/jsonb/jsonb_document_test.cpp.o`
- standalone JsonbPath nested escaped-member repro compiled and ran
successfully
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
