github-actions[bot] commented on code in PR #63730:
URL: https://github.com/apache/doris/pull/63730#discussion_r3322019254
##########
be/src/exprs/function/function_jsonb.cpp:
##########
@@ -2053,7 +2053,6 @@ class FunctionJsonbModify : public IFunction {
replace = true;
if
(!build_parents_by_path(json_documents[row_idx]->getValue(),
json_path[path_index],
parents)) {
- DCHECK(false);
continue;
}
Review Comment:
This removes the only Debug-time signal for a broken parent-chain invariant.
In this branch `find_result.value` was already found for the full path, so
`build_parents_by_path(...)` should be able to reconstruct the parent chain; if
it cannot, silently continuing skips the requested modification and hides the
inconsistency. If the intent is not to change release behavior, please keep the
existing `DCHECK(false)` before the `continue` instead of dropping the check.
```suggestion
DCHECK(false);
continue;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
