Gabriel39 opened a new pull request, #63796:
URL: https://github.com/apache/doris/pull/63796

   ### What problem does this PR solve?
   
   Issue Number: close #25509
   
   Related PR: #61248
   
   Problem Summary: S3/OSS prefetch timeout can cancel and close 
PrefetchBufferedReader while an async PrefetchBuffer task is still running. The 
task kept PrefetchBuffer alive but only stored the underlying FileReader as a 
raw pointer, so the owner could destroy the reader before the async task 
resumed on the error path and logged reader metadata. Keep a shared FileReader 
reference in each PrefetchBuffer so the async prefetch task cannot outlive the 
reader it dereferences, and add a unit test that covers close timeout while the 
prefetch read is blocked.
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test: git diff --check; git diff --cached --check; attempted 
build-support/clang-format.sh and build-support/check-format.sh but 
llvm@16/clang-format is not installed; attempted ./run-be-ut.sh --run 
buffered_reader_test but it failed before running tests because JAVA_HOME 
points to JDK 11 and JDK_17 is not set
   - Behavior changed: No
   - Does this need documentation: No
   
   ### What problem does this PR solve?
   
   Issue Number: close #xxx
   
   Related PR: #xxx
   
   Problem Summary:
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [ ] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [ ] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [ ] No.
       - [ ] Yes. <!-- Add document PR link here. eg: 
https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should 
merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to