starocean999 opened a new pull request, #63763:
URL: https://github.com/apache/doris/pull/63763
Problem Summary:
The rewrite in AggScalarSubQueryToWindowFunction.java partitioned the
generated window function only by the correlated slots. That assumption is not
sufficient when the outer query contains an additional relation whose rows are
duplicated under the same correlated key. In that situation, multiple distinct
outer rows are merged into the same window partition, so the rewritten window
aggregate is evaluated over join-amplified rows rather than over the logical
row set seen by the original correlated scalar subquery. The rule also kept
mutable matching state on the rewriter instance, which needed to be reset per
rewrite attempt.
Fix:
The fix changes the rewrite to partition the generated window function by
all visible slots from the outer-only relation, so different outer rows that
share the same correlated key remain isolated in separate window partitions.
This preserves the original scalar-subquery semantics even when the outer plan
has join-expanded rows.
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
