github-actions[bot] commented on code in PR #63729:
URL: https://github.com/apache/doris/pull/63729#discussion_r3309113049
##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -2639,7 +2639,7 @@ public class Config extends ConfigBase {
public static long analyze_record_limit = 20000;
@ConfField(mutable = true, masterOnly = true, description = {"Minimum
number of buckets for auto bucketing."})
- public static int autobucket_min_buckets = 1;
+ public static int autobucket_min_buckets = 3;
Review Comment:
This default is mutable and the existing auto-bucket regression suite still
restores it to the old value. In
`regression-test/suites/autobucket/test_autobucket.groovy`, after setting
`autobucket_min_buckets` to `5`, lines 64-65 reset it with `ADMIN SET FRONTEND
CONFIG ('autobucket_min_buckets' = '1')`. Regression suites share the same FE
process, so after that suite runs the cluster is left with min buckets = 1
instead of this new default of 3, which can mask this PR's behavior and pollute
later auto-bucket tests. Please update the test to restore `3`, or preferably
save and restore the previous value, and adjust/add coverage for the new
default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
