yiguolei commented on code in PR #63666:
URL: https://github.com/apache/doris/pull/63666#discussion_r3308652459
##########
be/src/exprs/vectorized_fn_call.cpp:
##########
@@ -686,17 +690,19 @@ Status VectorizedFnCall::evaluate_ann_range_search(
// If we expected distance but didn't get it, assert in debug to
catch logic errors.
DCHECK(!should_have_distance) << "Expected distance from ANN index
but got none";
#endif
- _virtual_column_is_fulfilled = false;
}
} else {
// Dest is not virtual column.
- _virtual_column_is_fulfilled = true;
+ dist_fulfilled = true;
}
- _has_been_executed = true;
+ if (evaluation_result != nullptr) {
Review Comment:
不要写这么多判断，强制外部一定要传一个evaluation_result，代码会简单可靠
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
