gavinchou commented on code in PR #63504:
URL: https://github.com/apache/doris/pull/63504#discussion_r3301919002
##########
be/src/io/cache/block_file_cache.cpp:
##########
@@ -348,6 +434,16 @@ BlockFileCache::BlockFileCache(const std::string&
cache_base_path,
_cache_base_path.c_str(), "file_cache_recycle_keys_length");
_need_update_lru_blocks_length_recorder =
std::make_shared<bvar::LatencyRecorder>(
_cache_base_path.c_str(),
"file_cache_need_update_lru_blocks_length");
+ _lru_recorder_ttl_log_queue_length_recorder =
std::make_shared<bvar::LatencyRecorder>(
Review Comment:
why do we need latency recorder, too many metrics, we need to keep minimal
metrics exposed to save scraping time.
a bvar<status> is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
