csun5285 opened a new pull request, #63661:
URL: https://github.com/apache/doris/pull/63661
Variant columns default variant_sparse_hash_shard_count to 0 internally.
SHOW CREATE TABLE used to emit `"variant_sparse_hash_shard_count" = "0"`, which
older Doris versions reject (range was [1, 1024]) when the same DDL is fed back
through CREATE TABLE LIKE, breaking DORIS-24269:
errCode = 2, detailMessage = variant_sparse_hash_shard_count
format error: ... must between 1 and 1024
Clamp the serialized value with Math.max(1, count) in both
nereids.types.VariantType and catalog.VariantType so the emitted DDL is
accepted by old and new versions. Existing parsing logic on master already
allows 0, so internal behaviour is unchanged.
Update the affected SHOW CREATE / DESC golden .out files to match the new
emitted value. Add a regression suite covering the CREATE TABLE -> CREATE TABLE
LIKE round-trip on a variant column with default properties.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
