Mryange opened a new pull request, #63652:
URL: https://github.com/apache/doris/pull/63652
### What problem does this PR solve?
Problem Summary:
The vertical block reader kept the delete filter column as the base
`ColumnPtr` type even though the column is always created as `ColumnUInt8` and
later mutated as a byte filter column. Root cause: `_delete_filter_column` used
the generic column pointer type, so the reader had to call `IColumn::mutate`
and reinterpret the result as `ColumnUInt8` before resizing and filling the
filter data. This PR changes the member to `ColumnUInt8::MutablePtr`, directly
operates on the concrete filter column, and moves it into the temporary block
filter column when applying `Block::filter_block`. The filter column is
recreated after filtering so the reader state remains valid on both success and
error paths.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
