Gabriel39 commented on code in PR #63376:
URL: https://github.com/apache/doris/pull/63376#discussion_r3300714115
##########
be/src/exec/scan/file_scanner.h:
##########
@@ -325,13 +325,8 @@ class FileScanner : public Scanner {
:
_local_state->get_push_down_agg_type();
}
- // enable the file meta cache only when
- // 1. max_external_file_meta_cache_num is > 0
- // 2. the file number is less than 1/3 of cache's capacibility
- // Otherwise, the cache miss rate will be high
bool _should_enable_file_meta_cache() {
- return ExecEnv::GetInstance()->file_meta_cache()->enabled() &&
- _split_source->num_scan_ranges() <
config::max_external_file_meta_cache_num / 3;
+ return
ExecEnv::GetInstance()->file_meta_cache()->should_enable_for_reader();
Review Comment:
这里直接用那个conf，把should_enable_for_reader这个函数删了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
