[GitHub] [doris] chenlinzhong commented on a diff in pull request #15224: [Feature](bitmap)Support return bitmap/hll data in select statement in vectoriza…

[GitBox]

chenlinzhong commented on code in PR #15224:
URL: https://github.com/apache/doris/pull/15224#discussion_r1053962689


##########
be/src/vec/sink/vmysql_result_writer.cpp:
##########
@@ -91,7 +92,17 @@ Status VMysqlResultWriter::_add_one_column(const ColumnPtr& 
column_ptr,
             }
 
             if constexpr (type == TYPE_OBJECT) {
-                buf_ret = _buffer.push_null();
+                if (column->is_bitmap() && output_object_data()) {
+                    vectorized::ColumnComplexType<BitmapValue>* tmp =
+                            
(vectorized::ColumnComplexType<BitmapValue>*)column.get();

Review Comment:
   fix



##########
be/src/vec/sink/vmysql_result_writer.cpp:
##########
@@ -91,7 +92,17 @@ Status VMysqlResultWriter::_add_one_column(const ColumnPtr& 
column_ptr,
             }
 
             if constexpr (type == TYPE_OBJECT) {
-                buf_ret = _buffer.push_null();
+                if (column->is_bitmap() && output_object_data()) {
+                    vectorized::ColumnComplexType<BitmapValue>* tmp =
+                            
(vectorized::ColumnComplexType<BitmapValue>*)column.get();
+                    BitmapValue bitmapValue = tmp->get_element(i);
+                    int size = bitmapValue.getSizeInBytes();
+                    char buf[size];

Review Comment:
   fix



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org