[GitHub] [doris] luozenglin commented on a diff in pull request #15114: [enhancement](gc) sub_file_cache checks the directory files when gc

[GitBox]

luozenglin commented on code in PR #15114:
URL: https://github.com/apache/doris/pull/15114#discussion_r1051974634


##########
be/src/io/cache/whole_file_cache.h:
##########
@@ -48,15 +48,17 @@ class WholeFileCache final : public FileCache {
 
     io::FileReaderSPtr remote_file_reader() const override { return 
_remote_file_reader; }
 
-    Status clean_timeout_cache() override;
+    Status clean_timeout_cache();
+
+    Status clean_cache_normal() override;
 
     Status clean_all_cache() override;
 
     Status clean_one_cache(size_t* cleaned_size) override;
 
-    int64_t get_oldest_match_time() const override { return _last_match_time; 
};
+    int64_t get_oldest_match_time() const override { return _gc_match_time; };

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org