924060929 commented on code in PR #14827:
URL: https://github.com/apache/doris/pull/14827#discussion_r1050639594


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rewrite/rules/FoldConstantRuleOnFE.java:
##########
@@ -59,143 +61,148 @@ public class FoldConstantRuleOnFE extends 
AbstractExpressionRewriteRule {
 
     @Override
     public Expression rewrite(Expression expr, ExpressionRewriteContext ctx) {
-        return process(expr, ctx);
-    }
+        if (expr instanceof AggregateFunction && ((AggregateFunction) 
expr).isDistinct()) {
+            return expr;
+        } else if (expr instanceof AggregateExpression && 
((AggregateExpression) expr).getFunction().isDistinct()) {
+            return expr;

Review Comment:
   maybe erase some distinct columns, that will be some bug



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to