liaoxin01 commented on code in PR #15101:
URL: https://github.com/apache/doris/pull/15101#discussion_r1049527760
##########
gensrc/proto/internal_service.proto:
##########
@@ -65,6 +65,8 @@ message PTabletInfo {
// Delta Writer will write data to local disk and then check if there are
new raw values not in global dict
// if appears, then it should add the column name to this vector
repeated string invalid_dict_cols = 3;
+ // total rows num written by DeltaWriter
+ optional int64 num_rows = 4;
Review Comment:
fixed.
##########
be/src/olap/delta_writer.cpp:
##########
@@ -358,6 +362,12 @@ Status DeltaWriter::close_wait(const PSlaveTabletNodes&
slave_tablet_nodes,
_mem_table.reset();
+ if (_rowset_writer->num_rows() + _merged_rows != _total_rows) {
+ LOG(WARNING) << "the rows number written doesn't match, rowset
num_rows: "
Review Comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
