Gabriel39 commented on code in PR #15072:
URL: https://github.com/apache/doris/pull/15072#discussion_r1049500945
##########
be/src/vec/common/hash_table/hash_table.h:
##########
@@ -349,11 +350,13 @@ class alignas(64) HashTableGrowerWithPrecalculation {
: ((initial_size_degree >
static_cast<size_t>(log2(num_elems - 1)) + 2)
? initial_size_degree
: (static_cast<size_t>(log2(num_elems - 1))
+ 2));
+ DCHECK(size_degree_ <= 64);
increase_size_degree(0);
}
void set_buf_size(size_t buf_size_) {
size_degree_ = static_cast<size_t>(log2(buf_size_ - 1) + 1);
+ DCHECK(size_degree_ <= 64);
Review Comment:
ditto
##########
be/src/vec/common/hash_table/hash_table.h:
##########
@@ -349,11 +350,13 @@ class alignas(64) HashTableGrowerWithPrecalculation {
: ((initial_size_degree >
static_cast<size_t>(log2(num_elems - 1)) + 2)
? initial_size_degree
: (static_cast<size_t>(log2(num_elems - 1))
+ 2));
+ DCHECK(size_degree_ <= 64);
Review Comment:
There is a DCHECK in `increase_size_degree` already so this can be deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
