platoneko commented on code in PR #15030: URL: https://github.com/apache/doris/pull/15030#discussion_r1046783041
########## be/src/http/action/pad_rowset_action.cpp: ########## @@ -0,0 +1,90 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "http/action/pad_rowset_action.h" + +#include <memory> + +#include "http/http_channel.h" +#include "olap/olap_common.h" +#include "olap/rowset/beta_rowset_writer.h" +#include "olap/rowset/rowset.h" +#include "olap/storage_engine.h" + +namespace doris { + +const std::string TABLET_ID = "tablet_id"; +const std::string VERSION = "version"; + +void PadRowsetAction::handle(HttpRequest* req) { + LOG(INFO) << "accept one request " << req->debug_string(); + Status status = _handle(req); + std::string result = status.to_json(); + LOG(INFO) << "handle request result:" << result; + if (status.ok()) { + HttpChannel::send_reply(req, HttpStatus::OK, result); + } else { + HttpChannel::send_reply(req, HttpStatus::INTERNAL_SERVER_ERROR, result); + } +} + +Status PadRowsetAction::_handle(HttpRequest* req) { + // Get tablet id + const std::string& tablet_id_str = req->param(TABLET_ID); + if (tablet_id_str.empty()) { + std::string error_msg = std::string("parameter " + TABLET_ID + " not specified in url."); + return Status::InternalError(error_msg); + } + + // Get schema hash + const std::string& version_str = req->param(VERSION); + if (version_str.empty()) { + std::string error_msg = std::string("parameter " + VERSION + " not specified in url."); + return Status::InternalError(error_msg); + } + + // valid str format + int64_t tablet_id = std::atol(tablet_id_str.c_str()); + int32_t version = std::atoi(version_str.c_str()); Review Comment: start_version, end_version may not be equal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
