github-actions[bot] commented on code in PR #14868:
URL: https://github.com/apache/doris/pull/14868#discussion_r1043322078
##########
be/src/pipeline/pipeline_fragment_context.cpp:
##########
@@ -372,219 +376,252 @@
RETURN_IF_ERROR(cur_pipe->add_operator(join_source));
cur_pipe->add_dependency(new_pipe);
+ case TPlanNodeType::INTERSECT_NODE: {
+ RETURN_IF_ERROR(_build_operators_for_set_operation_node<true>(node,
cur_pipe));
+ break;
+ }
+ case TPlanNodeType::EXCEPT_NODE: {
Review Comment:
warning: cannot jump from switch statement to this case label
[clang-diagnostic-error]
```cpp
}
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:373:** jump bypasses
variable initialization
```cpp
;
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:368:** jump bypasses
variable initialization
```cpp
;
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:366:** jump bypasses
variable initialization
```cpp
;
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:365:** jump bypasses
variable initialization
```cpp
{
^
```
##########
be/src/pipeline/pipeline_fragment_context.cpp:
##########
@@ -372,219 +376,252 @@
RETURN_IF_ERROR(cur_pipe->add_operator(join_source));
cur_pipe->add_dependency(new_pipe);
+ case TPlanNodeType::INTERSECT_NODE: {
+ RETURN_IF_ERROR(_build_operators_for_set_operation_node<true>(node,
cur_pipe));
+ break;
+ }
+ case TPlanNodeType::EXCEPT_NODE: {
+ RETURN_IF_ERROR(_build_operators_for_set_operation_node<false>(node,
cur_pipe));
break;
}
default:
return Status::InternalError("Unsupported exec type in pipeline: {}",
print_plan_node_type(node_type));
}
- return Status::OK();
-}
+ return Status::OK();
+ }
+
+ template <bool is_intersect>
Review Comment:
warning: expected expression [clang-diagnostic-error]
```cpp
^
```
##########
be/src/pipeline/pipeline_fragment_context.cpp:
##########
@@ -372,219 +376,252 @@
RETURN_IF_ERROR(cur_pipe->add_operator(join_source));
cur_pipe->add_dependency(new_pipe);
+ case TPlanNodeType::INTERSECT_NODE: {
+ RETURN_IF_ERROR(_build_operators_for_set_operation_node<true>(node,
cur_pipe));
+ break;
+ }
+ case TPlanNodeType::EXCEPT_NODE: {
+ RETURN_IF_ERROR(_build_operators_for_set_operation_node<false>(node,
cur_pipe));
break;
}
default:
Review Comment:
warning: cannot jump from switch statement to this case label
[clang-diagnostic-error]
```cpp
}
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:373:** jump bypasses
variable initialization
```cpp
;
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:368:** jump bypasses
variable initialization
```cpp
;
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:366:** jump bypasses
variable initialization
```cpp
;
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:365:** jump bypasses
variable initialization
```cpp
{
^
```
##########
be/src/pipeline/pipeline_fragment_context.cpp:
##########
@@ -372,219 +376,252 @@ Status
PipelineFragmentContext::_build_pipelines(ExecNode* node, PipelinePtr cur
RETURN_IF_ERROR(cur_pipe->add_operator(join_source));
cur_pipe->add_dependency(new_pipe);
+ case TPlanNodeType::INTERSECT_NODE: {
Review Comment:
warning: cannot jump from switch statement to this case label
[clang-diagnostic-error]
```cpp
;
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:373:** jump bypasses
variable initialization
```cpp
;
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:368:** jump bypasses
variable initialization
```cpp
;
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:366:** jump bypasses
variable initialization
```cpp
;
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:365:** jump bypasses
variable initialization
```cpp
{
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
