luozenglin commented on code in PR #14920:
URL: https://github.com/apache/doris/pull/14920#discussion_r1043052867
##########
be/src/io/cache/file_cache_manager.cpp:
##########
@@ -175,16 +193,21 @@ void FileCacheManager::gc_file_caches() {
// policy2: GC file cache by disk size
if (gc_conf_size > 0) {
for (size_t i = 0; i < contexts.size(); ++i) {
- std::list<FileCachePtr> gc_file_list;
- contexts[i].get_gc_file_caches(gc_file_list);
- for (auto item : gc_file_list) {
- std::shared_lock<std::shared_mutex> rdlock(_cache_map_lock);
- // for dummy file cache, check already used or not again
- if (item->is_dummy_file_cache() &&
- _file_cache_map.find(item->cache_dir().native()) !=
_file_cache_map.end()) {
- continue;
+ auto context = contexts[i];
Review Comment:
replaced with auto&. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
