github-actions[bot] commented on code in PR #62302: URL: https://github.com/apache/doris/pull/62302#discussion_r3059567002
########## .github/workflows/pr-approve-status.yml: ########## @@ -1,43 +0,0 @@ -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, -# software distributed under the License is distributed on an -# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY -# KIND, either express or implied. See the License for the -# specific language governing permissions and limitations -# under the License. ---- -name: Need_2_Approval Review Comment: Deleting the only workflow named `Need_2_Approval` breaks `master` branch protection as currently configured: `.asf.yaml:65` still lists that context under `required_status_checks`, and `grep` shows there is no other workflow left that publishes the same status. Once this lands, every PR to `master` will be missing a required check forever. If the intent is to retire this gate, the protection config has to change in the same PR; otherwise we need a replacement workflow/job that preserves the context. ########## .github/workflows/opencode-review.yml: ########## @@ -89,23 +93,23 @@ jobs: - If issues found, submit a review with inline comments plus a comprehensive summary body. Use GitHub Reviews API to ensure comments are inline: - Inline comment bodies may include GitHub suggested changes blocks when you can propose a precise patch. - Prefer suggested changes for small, self-contained fixes (for example typos, trivial refactors, or narrowly scoped code corrections). - - Do not force suggested changes for broad, architectural, or multi-file issues; explain those normally. - Build a JSON array of comments like: [{ "path": "<file>", "position": <diff_position>, "body": "..." }] - Submit via: gh api repos/PLACEHOLDER_REPO/pulls/PLACEHOLDER_PR_NUMBER/reviews --input <json_file> Review Comment: This flips the automation contract. The existing prompt and the runner instructions require the bot to leave either a plain PR comment or a `COMMENT` review via `gh api .../reviews`, explicitly not an `APPROVED`/`CHANGES_REQUESTED` review. Telling the model to run `gh pr review --approve` / `--request-changes` will make it mutate the PR's approval state directly instead of leaving non-blocking review comments. ```suggestion - Do not use: gh pr review --approve or --request-changes ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
