github-actions[bot] commented on PR #62299: URL: https://github.com/apache/doris/pull/62299#issuecomment-4214989634
No issues found in this review. Critical checkpoints: - Goal and correctness: The change addresses the reported unsound pull-up predicate for constant-only `UNION ALL` NULL rows, and the added regression coverage exercises the reported `INTERSECT`/`EXCEPT` behavior plus several NULL variants. - Scope/minimality: The code change is small and focused to `PullUpPredicates.getFiltersFromUnionConstExprs()` with matching regression tests. - Concurrency: Not applicable; this FE optimizer rewrite path is single-threaded here and introduces no new shared-state or locking behavior. - Lifecycle/static init: Not applicable; no lifecycle or static initialization changes. - Configuration: None added. - Compatibility: No FE/BE protocol, storage format, or rolling-upgrade compatibility impact. - Parallel code paths: I checked the surrounding `InferPredicates` and set-operation pull-up flow; the new predicate shape is consumed consistently in the affected path. - Special conditions: The new NULL handling condition is necessary and matches SQL three-valued logic for valid pulled-up predicates. - Test coverage: Regression coverage is good for the reported bug and nearby NULL cases. Residual gap: there is still no dedicated case for a mixed `LogicalUnion` containing both regular children and `constantExprsList`, though I did not identify a correctness bug in that path from this patch. - Observability: No new observability needed for this optimizer-only fix. - Transaction/persistence/data-write concerns: Not applicable. - Performance: No material concern; the added predicate construction is trivial and stays off hot execution paths. - Other issues: None found. Overall opinion: acceptable as-is based on the reviewed diff and surrounding optimizer flow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
