zhangstar333 commented on code in PR #13741:
URL: https://github.com/apache/doris/pull/13741#discussion_r1041845348
##########
be/src/vec/functions/function_string.h:
##########
@@ -1351,6 +1352,124 @@ class FunctionSplitPart : public IFunction {
}
};
+class FunctionSplitByString : public IFunction {
+public:
+ static constexpr auto name = "split_by_string";
+
+ static FunctionPtr create() { return
std::make_shared<FunctionSplitByString>(); }
+ using NullMapType = PaddedPODArray<UInt8>;
+
+ String get_name() const override { return name; }
+
+ bool is_variadic() const override { return false; }
+
+ size_t get_number_of_arguments() const override { return 2; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
+ return std::make_shared<DataTypeArray>(make_nullable(arguments[0]));
+ }
+
+ Status execute_impl(FunctionContext* /*context*/, Block& block, const
ColumnNumbers& arguments,
+ size_t result, size_t /*input_rows_count*/) override {
+ DCHECK_EQ(arguments.size(), 2);
+
+ ColumnPtr src_column =
+
block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
+ ColumnPtr delimiter_column =
+
block.get_by_position(arguments[1]).column->convert_to_full_column_if_const();
+
+ DataTypePtr src_column_type = block.get_by_position(arguments[0]).type;
+ auto dest_column_ptr =
ColumnArray::create(make_nullable(src_column_type)->create_column(),
+
ColumnArray::ColumnOffsets::create());
+
+ IColumn* dest_nested_column = &dest_column_ptr->get_data();
+ auto& dest_offsets = dest_column_ptr->get_offsets();
+ DCHECK(dest_nested_column != nullptr);
+ dest_nested_column->reserve(0);
+ dest_offsets.reserve(0);
+
+ NullMapType* dest_nested_null_map = nullptr;
+ if (dest_nested_column->is_nullable()) {
Review Comment:
here seems always be true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
