BiteTheDDDDt commented on code in PR #62043:
URL: https://github.com/apache/doris/pull/62043#discussion_r3031686528
##########
be/src/exprs/aggregate/aggregate_function_window_funnel_v2.h:
##########
@@ -423,8 +423,14 @@ struct WindowFunnelStateV2 {
int event_idx = get_event_idx(evt.event_idx) - 1;
if (event_idx == 0) {
- // Duplicate of event 0: terminate current chain first
+ // Duplicate of event 0: terminate current chain first.
+ // However, if this E0 is from the same row as an event already
+ // in the chain, it's a multi-match row — not a true duplicate.
+ // V1 doesn't break chains on same-row events, so skip it.
if (events_timestamp[0].has_value()) {
+ if (_is_same_row_as_chain(i, curr_level,
events_timestamp)) {
Review Comment:
这个应该不算问题，只是语义上的diff
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
