github-actions[bot] commented on code in PR #61996: URL: https://github.com/apache/doris/pull/61996#discussion_r3026991220
########## be/src/core/data_type_serde/data_type_date_serde.cpp: ########## @@ -244,17 +193,17 @@ Status DataTypeDateSerDe<T>::_read_column_from_arrow(IColumn& column, } template <PrimitiveType T> -Status DataTypeDateSerDe<T>::read_column_from_arrow(IColumn& column, Review Comment: `write_column_to_pb()` is newly split out here, but it still populates protobuf by reinterpreting the `VecDateTimeValue` object buffer as `int64_t*`. That relies on object layout/aliasing assumptions and is undefined behavior under optimization. Please append each row through an explicit representation-safe conversion instead, e.g. `binary_cast<VecDateTimeValue, Int64>(data[i])`, rather than passing a reinterpreted raw pointer range to protobuf. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
