github-actions[bot] commented on PR #61890: URL: https://github.com/apache/doris/pull/61890#issuecomment-4174122121
No issues found in this PR. Critical checkpoint conclusions: - Goal and correctness: The change fixes the reported UnsupportedOperationException in RestoreCommand.analyzeProperties() for immutable property maps, and the added unit test covers the failing path. - Change scope: The modification is minimal and focused to the offending mutation site. - Concurrency: No new concurrency or locking behavior is introduced. - Lifecycle/static init: No lifecycle or static initialization concerns are involved. - Configuration: No new configuration items are added. - Compatibility: No FE/BE protocol, symbol, or storage-format compatibility changes are involved. - Parallel paths: The reachable SQL/Nereids restore path now handles immutable maps correctly; no other equivalent changed path was missed in this fix. - Conditional checks: The existing property validation logic remains consistent and understandable. - Test coverage: The new FE unit test exercises the immutable-map case directly; no regression gap specific to this fix was found. - Observability: No additional observability is needed for this small validation-path fix. - Transaction/persistence: No transaction, EditLog, or persistence logic is changed. - Data writes/modifications: No data-write atomicity or crash-consistency behavior is affected. - FE/BE variable passing: No new cross-component variables are added. - Performance: The added defensive copy is small, local to analysis, and acceptable for this non-hot path. - Other issues: None found. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
