JNSimba opened a new pull request, #62010:
URL: https://github.com/apache/doris/pull/62010
### What problem does this PR solve?
### What problem does this PR solve?
Problem Summary:
When a PostgreSQL CDC streaming job is paused and resumed, the PG
replication slot
can be permanently leaked, causing all subsequent tasks to fail with:
`replication slot "doris_cdc_xxx" is active for PID xxx`
**Root cause:**
The CDC client reuses a single `SourceReader` instance per jobId
(`Env.getOrCreateReader`).
When FE cancels a task (PAUSE), the BE HTTP connection is closed, but the
CDC client's
`buildStreamRecords` thread may still be blocked in `pollRecords` (up to
15s timeout).
Before the old task finishes, the new task (after RESUME) arrives at the
same CDC client
and calls `prepareStreamSplit`, which overwrites `this.streamReader` with
a new Fetcher
without closing the old one. The old Debezium reader (holding the PG
replication connection)
is leaked — its reference is lost, so `finishSplitRecords` in the old
task's finally block
closes the new Fetcher instead, and the PG slot is never released.
From the logs, the slot remained occupied for 25+ minutes until the test
timed out:
Failed to start replication stream at LSN{0/318EBC8}; when setting up
multiple connectors
for the same database host, please make sure to use a distinct replication
slot name for each.
**Fix:**
Close the previous stream/binlog reader before creating a new one in
`prepareStreamSplit` (PG) and `prepareBinlogSplit` (MySQL). This ensures
the old
Debezium connection is properly released when a new task reuses the same
SourceReader.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
