This is an automated email from the ASF dual-hosted git repository.
gavinchou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 6e3c531c16a [minor](Prefetch) Revert some useless check (#59601)
6e3c531c16a is described below
commit 6e3c531c16ab41d09e47f20d2ee53fee9019413c
Author: 黄瑞鑫 <[email protected]>
AuthorDate: Wed Apr 1 16:45:19 2026 +0800
[minor](Prefetch) Revert some useless check (#59601)
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
maybe useless long time check
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [x] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
---
be/src/io/fs/buffered_reader.cpp | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/be/src/io/fs/buffered_reader.cpp b/be/src/io/fs/buffered_reader.cpp
index 5f9e4d63a8b..637a7541cc7 100644
--- a/be/src/io/fs/buffered_reader.cpp
+++ b/be/src/io/fs/buffered_reader.cpp
@@ -567,10 +567,6 @@ Status PrefetchBuffer::read_buffer(size_t off, const char*
out, size_t buf_len,
reset_offset((off / _size) * _size);
return read_buffer(off, out, buf_len, bytes_read);
}
- auto start = std::chrono::steady_clock::now();
- // The baseline time is calculated by dividing the size of each buffer by
MB/s.
- // If it exceeds this value, it is considered a slow I/O operation.
- constexpr auto read_time_baseline =
std::chrono::seconds(s_max_pre_buffer_size / 1024 / 1024);
{
std::unique_lock lck {_lock};
// buffer must be prefetched or it's closed
@@ -587,11 +583,6 @@ Status PrefetchBuffer::read_buffer(size_t off, const char*
out, size_t buf_len,
return Status::OK();
}
}
- auto duration = std::chrono::duration_cast<std::chrono::seconds>(
- std::chrono::steady_clock::now() - start);
- if (duration > read_time_baseline) [[unlikely]] {
- LOG_WARNING("The prefetch io is too slow");
- }
RETURN_IF_ERROR(_prefetch_status);
// there is only parquet would do not sequence read
// it would read the end of the file first
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
