github-actions[bot] commented on PR #61989: URL: https://github.com/apache/doris/pull/61989#issuecomment-4168383099
No issues found after reviewing the pipeline task state-transition change. The BLOCKED->FINISHED exception is narrowly scoped to the _wake_up_early race, the delayed dependency wake-up path now safely ignores stale wake-ups after task completion, and the added unit coverage exercises both the special transition and the stale wake-up case.\n\nCheckpoint summary:\n- Goal / correctness: The change addresses the intended wake_up_early race and the updated tests cover the new behavior.\n- Scope: The modification is small and focused to PipelineTask state handling plus targeted tests.\n- Concurrency: The review traced Pipeline::make_all_runnable(), Dependency::set_ready(), PipelineTask::execute(), wake_up(), close(), and finalize(); the new logic is consistent with the existing locking and atomic usage.\n- Lifecycle: No new special lifecycle or static-init risk introduced.\n- Compatibility / config: No compatibility or configuration impact.\n- Parallel paths: The relevant wake-up and cl ose paths are covered by the change.\n- Conditional checks: The new special-case transition is documented in code and constrained to _wake_up_early.\n- Test coverage: Targeted BE unit tests were added for the new transition and stale wake-up handling.\n- Observability: Existing debug_string/profile info remains sufficient for this change.\n- Transaction / persistence / data writes / FE-BE protocol: Not applicable for this PR.\n- Performance: No material performance concern found in the modified hot path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
