github-actions[bot] commented on PR #61997: URL: https://github.com/apache/doris/pull/61997#issuecomment-4168353137
No issues found after review. Critical checkpoints: - Goal/completeness: The change is focused on persisting `StreamingInsertJob.jobStatistic` into FE images so restart recovery preserves streaming load statistics; the new regression case exercises both mid-snapshot and binlog-phase FE restart recovery and matches that goal. - Scope/minimality: The production fix is minimal (`@SerializedName` on the missing persisted field) and the remaining diff is targeted regression coverage. - Concurrency/locking: No new concurrency path or lock-order change is introduced; the patch only affects persisted metadata and tests. - Lifecycle/static init: No special lifecycle or static initialization risk added. - Config/compatibility: No new config is added. The change only adds persisted image coverage for an existing field and does not alter FE-BE protocol or storage format semantics. - Parallel paths: The affected path is the FE checkpoint/image replay path for streaming insert jobs; the existing txn replay path remains unchanged and consistent with the fix. - Conditional logic: No new correctness-sensitive conditional branch is added in production code. - Test coverage: Regression coverage is strong for the intended bug, including both snapshot and binlog recovery after FE restart. - Observability: Existing job/task inspection in the regression case is sufficient; no additional observability gap is introduced. - Transaction/persistence correctness: The review of image serialization, job reload, and offset replay path did not reveal missing replay or persistence steps for this change. - Data write atomicity/correctness: No data-write semantics changed beyond preserving already-committed statistics across FE restart. - FE-BE variable passing: No new FE-BE transmitted field is introduced. - Performance: No meaningful hot-path regression is introduced. Residual risk: I did not run the regression suite in this review environment, so the conclusion is based on code inspection and the submitted regression coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
