Copilot commented on code in PR #61947:
URL: https://github.com/apache/doris/pull/61947#discussion_r3015200031
##########
regression-test/suites/compaction/test_mow_compaction_and_rowset_not_exist.groovy:
##########
@@ -283,10 +283,13 @@ suite("test_mow_compaction_and_rowset_not_exist",
"nonConcurrent") {
sleep(2000)
}
assertEquals(3, tablet_status["rowsets"].size())
+ def ms_dm = getMsDeleteBitmapStatus(tablet)
+ logger.info("ms_dm 2: " + ms_dm)
+ assertEquals(1, ms_dm["delete_bitmap_count"])
+ assertEquals(5, ms_dm["cardinality"])
+ // for local delete bitmap, the unused rowsets may be not deleted
because of rowset reference count
Review Comment:
Here `local_dm` is assigned from `getMsDeleteBitmapStatus(tablet)` and then
logged as `ms_dm 2`, which makes the variable name/comment misleading and can
cause confusion later when `local_dm` is reused for local delete bitmap status.
Please use a separate `ms_dm` variable (consistent with other tests) and keep
`local_dm` for local status.
##########
regression-test/suites/compaction/test_mow_compaction_and_rowset_not_exist.groovy:
##########
@@ -269,7 +269,7 @@ suite("test_mow_compaction_and_rowset_not_exist",
"nonConcurrent") {
logger.info("local_dm 1: " + local_dm)
// block merge delete bitmap
-
GetDebugPoint().enableDebugPointForAllBEs("CumulativeCompaction.modify_rowsets.cloud_update_delete_bitmap_without_lock.block")
+ //
GetDebugPoint().enableDebugPointForAllBEs("CumulativeCompaction.modify_rowsets.cloud_update_delete_bitmap_without_lock.block")
// trigger compaction
Review Comment:
The test says "block merge delete bitmap" but the debug point that actually
blocks it is commented out. Either re-enable the debug point (if the scenario
is required for this case) or remove the stale comment / commented-out line and
explain the new test intent, since leaving disabled debug-point code makes the
test behavior unclear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
