github-actions[bot] commented on code in PR #14825:
URL: https://github.com/apache/doris/pull/14825#discussion_r1039382236
##########
be/src/vec/exec/scan/vscan_node.h:
##########
@@ -132,18 +132,21 @@ class VScanNode : public ExecNode {
// 2. in/not in predicate
// 3. function predicate
// TODO: these interfaces should be change to become more common.
- virtual PushDownType _should_push_down_binary_predicate(
+ virtual Status _should_push_down_binary_predicate(
VectorizedFnCall* fn_call, VExprContext* expr_ctx, StringRef*
constant_val,
- int* slot_ref_child, const std::function<bool(const
std::string&)>& fn_checker);
+ int* slot_ref_child, const std::function<bool(const
std::string&)>& fn_checker,
+ PushDownType& pdt);
virtual PushDownType _should_push_down_in_predicate(VInPredicate* in_pred,
VExprContext*
expr_ctx, bool is_not_in);
- virtual PushDownType _should_push_down_function_filter(VectorizedFnCall*
fn_call,
- VExprContext*
expr_ctx,
- StringVal*
constant_str,
-
doris_udf::FunctionContext** fn_ctx) {
- return PushDownType::UNACCEPTABLE;
+ virtual Status _should_push_down_function_filter(VectorizedFnCall* fn_call,
Review Comment:
warning: parameter 'fn_call' is unused [misc-unused-parameters]
```suggestion
virtual Status _should_push_down_function_filter(VectorizedFnCall*
/*fn_call*/,
```
##########
be/src/vec/exec/scan/vscan_node.h:
##########
@@ -132,18 +132,21 @@
// 2. in/not in predicate
// 3. function predicate
// TODO: these interfaces should be change to become more common.
- virtual PushDownType _should_push_down_binary_predicate(
+ virtual Status _should_push_down_binary_predicate(
VectorizedFnCall* fn_call, VExprContext* expr_ctx, StringRef*
constant_val,
- int* slot_ref_child, const std::function<bool(const
std::string&)>& fn_checker);
+ int* slot_ref_child, const std::function<bool(const
std::string&)>& fn_checker,
+ PushDownType& pdt);
virtual PushDownType _should_push_down_in_predicate(VInPredicate* in_pred,
VExprContext*
expr_ctx, bool is_not_in);
- virtual PushDownType _should_push_down_function_filter(VectorizedFnCall*
fn_call,
- VExprContext*
expr_ctx,
- StringVal*
constant_str,
-
doris_udf::FunctionContext** fn_ctx) {
- return PushDownType::UNACCEPTABLE;
+ virtual Status _should_push_down_function_filter(VectorizedFnCall* fn_call,
+ VExprContext* expr_ctx,
+ StringVal* constant_str,
Review Comment:
warning: parameter 'constant_str' is unused [misc-unused-parameters]
```suggestion
StringVal*
/*constant_str*/,
```
##########
be/src/vec/exec/scan/vscan_node.h:
##########
@@ -132,18 +132,21 @@
// 2. in/not in predicate
// 3. function predicate
// TODO: these interfaces should be change to become more common.
- virtual PushDownType _should_push_down_binary_predicate(
+ virtual Status _should_push_down_binary_predicate(
VectorizedFnCall* fn_call, VExprContext* expr_ctx, StringRef*
constant_val,
- int* slot_ref_child, const std::function<bool(const
std::string&)>& fn_checker);
+ int* slot_ref_child, const std::function<bool(const
std::string&)>& fn_checker,
+ PushDownType& pdt);
virtual PushDownType _should_push_down_in_predicate(VInPredicate* in_pred,
VExprContext*
expr_ctx, bool is_not_in);
- virtual PushDownType _should_push_down_function_filter(VectorizedFnCall*
fn_call,
- VExprContext*
expr_ctx,
- StringVal*
constant_str,
-
doris_udf::FunctionContext** fn_ctx) {
- return PushDownType::UNACCEPTABLE;
+ virtual Status _should_push_down_function_filter(VectorizedFnCall* fn_call,
+ VExprContext* expr_ctx,
+ StringVal* constant_str,
+
doris_udf::FunctionContext** fn_ctx,
Review Comment:
warning: parameter 'fn_ctx' is unused [misc-unused-parameters]
```suggestion
doris_udf::FunctionContext** /*fn_ctx*/,
```
##########
be/src/vec/exec/scan/vscan_node.h:
##########
@@ -132,18 +132,21 @@
// 2. in/not in predicate
// 3. function predicate
// TODO: these interfaces should be change to become more common.
- virtual PushDownType _should_push_down_binary_predicate(
+ virtual Status _should_push_down_binary_predicate(
VectorizedFnCall* fn_call, VExprContext* expr_ctx, StringRef*
constant_val,
- int* slot_ref_child, const std::function<bool(const
std::string&)>& fn_checker);
+ int* slot_ref_child, const std::function<bool(const
std::string&)>& fn_checker,
+ PushDownType& pdt);
virtual PushDownType _should_push_down_in_predicate(VInPredicate* in_pred,
VExprContext*
expr_ctx, bool is_not_in);
- virtual PushDownType _should_push_down_function_filter(VectorizedFnCall*
fn_call,
- VExprContext*
expr_ctx,
- StringVal*
constant_str,
-
doris_udf::FunctionContext** fn_ctx) {
- return PushDownType::UNACCEPTABLE;
+ virtual Status _should_push_down_function_filter(VectorizedFnCall* fn_call,
+ VExprContext* expr_ctx,
Review Comment:
warning: parameter 'expr_ctx' is unused [misc-unused-parameters]
```suggestion
VExprContext*
/*expr_ctx*/,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
