Copilot commented on code in PR #3506:
URL: https://github.com/apache/doris-website/pull/3506#discussion_r3013117153
##########
docs/sql-manual/sql-functions/aggregate-functions/window-funnel.md:
##########
@@ -218,13 +218,13 @@ order BY
+---------+-------+
| user_id | level |
+---------+-------+
-| 100123 | 3 |
+| 100123 | 4 |
| 100125 | 3 |
| 100126 | 2 |
| 100127 | 2 |
+---------+-------+
```
-For `uesr_id=100123`, after matching the `order` event, the event chain is
interrupted by the `login2` event, so the matched event chain is
`login-visit-order`.
+For `uesr_id=100123`, `login2` does not match any condition in the funnel.
Starting from Doris 4.1, such unrelated events do not break the `fixed` chain,
so the matched event chain is `login-visit-order-payment`. In Doris versions
earlier than 4.1, the same data would stop at `login-visit` and return level
`2`.
Review Comment:
`uesr_id` appears to be a typo; it should be `user_id` to match the column
name used throughout the examples and avoid confusing readers.
##########
ja-source/docusaurus-plugin-content-docs/version-4.x/sql-manual/sql-functions/aggregate-functions/window-funnel.md:
##########
@@ -212,13 +212,13 @@ order BY
+---------+-------+
| user_id | level |
+---------+-------+
-| 100123 | 3 |
+| 100123 | 4 |
| 100125 | 3 |
| 100126 | 2 |
| 100127 | 2 |
+---------+-------+
```
-`uesr_id=100123`の場合、`order`イベントにマッチした後、イベントチェーンは`login2`イベントによって中断されるため、マッチしたイベントチェーンは`login-visit-order`となります。
+`uesr_id=100123` の場合、`login2` はファネル内のどの条件にも一致しません。Doris 4.1
以降では、このような無関係なイベントは `fixed` モードのチェーンを中断しないため、一致したイベントチェーンは
`login-visit-order-payment` になります。4.1 より前のバージョンでは、同じデータは `login2`
の位置で中断され、`login-visit`、レベル `2` で停止します。
Review Comment:
`uesr_id` appears to be a typo (user_id). Keeping the spelling consistent
with the column name helps avoid confusion in the examples.
##########
docs/sql-manual/sql-functions/aggregate-functions/window-funnel.md:
##########
@@ -184,8 +184,8 @@ INSERT INTO
VALUES
(100123, 'login', '2022-05-14 10:01:00', 'HONOR', 1),
(100123, 'visit', '2022-05-14 10:02:00', 'HONOR', 2),
- (100123, 'order', '2022-05-14 10:03:00', "HONOR", 4),
- (100123, 'login2', '2022-05-14 10:04:00', 'HONOR', 3),
+ (100123, 'login2', '2022-05-14 10:03:00', 'HONOR', 3),
+ (100123, 'order', '2022-05-14 10:04:00', "HONOR", 4),
Review Comment:
In this INSERT example, "HONOR" is quoted with double-quotes while other
string literals use single quotes. In SQL, double quotes are typically
identifiers, so this can be misleading or invalid depending on SQL mode; use
single quotes for the string literal for consistency.
##########
ja-source/docusaurus-plugin-content-docs/current/sql-manual/sql-functions/aggregate-functions/window-funnel.md:
##########
@@ -212,13 +212,13 @@ order BY
+---------+-------+
| user_id | level |
+---------+-------+
-| 100123 | 3 |
+| 100123 | 4 |
| 100125 | 3 |
| 100126 | 2 |
| 100127 | 2 |
+---------+-------+
```
-`uesr_id=100123`の場合、`order`イベントをマッチした後、`login2`イベントによってイベントチェーンが中断されるため、マッチしたイベントチェーンは`login-visit-order`となります。
+`uesr_id=100123` の場合、`login2` はファネル内のどの条件にも一致しません。Doris 4.1
以降では、このような無関係なイベントは `fixed` モードのチェーンを中断しないため、一致したイベントチェーンは
`login-visit-order-payment` になります。4.1 より前のバージョンでは、同じデータは `login2`
の位置で中断され、`login-visit`、レベル `2` で停止します。
Review Comment:
`uesr_id` appears to be a typo (user_id). Keeping the spelling consistent
with the column name helps avoid confusion in the examples.
##########
versioned_docs/version-4.x/sql-manual/sql-functions/aggregate-functions/window-funnel.md:
##########
@@ -184,8 +184,8 @@ INSERT INTO
VALUES
(100123, 'login', '2022-05-14 10:01:00', 'HONOR', 1),
(100123, 'visit', '2022-05-14 10:02:00', 'HONOR', 2),
- (100123, 'order', '2022-05-14 10:03:00', "HONOR", 4),
- (100123, 'login2', '2022-05-14 10:04:00', 'HONOR', 3),
+ (100123, 'login2', '2022-05-14 10:03:00', 'HONOR', 3),
+ (100123, 'order', '2022-05-14 10:04:00', "HONOR", 4),
Review Comment:
In this INSERT example, "HONOR" is quoted with double-quotes while other
string literals use single quotes. In SQL, double quotes are typically
identifiers, so this can be misleading or invalid depending on SQL mode; use
single quotes for the string literal for consistency.
```suggestion
(100123, 'order', '2022-05-14 10:04:00', 'HONOR', 4),
```
##########
ja-source/docusaurus-plugin-content-docs/current/sql-manual/sql-functions/aggregate-functions/window-funnel.md:
##########
@@ -179,8 +179,8 @@ INSERT INTO
VALUES
(100123, 'login', '2022-05-14 10:01:00', 'HONOR', 1),
(100123, 'visit', '2022-05-14 10:02:00', 'HONOR', 2),
- (100123, 'order', '2022-05-14 10:03:00', "HONOR", 4),
- (100123, 'login2', '2022-05-14 10:04:00', 'HONOR', 3),
+ (100123, 'login2', '2022-05-14 10:03:00', 'HONOR', 3),
+ (100123, 'order', '2022-05-14 10:04:00', "HONOR", 4),
Review Comment:
The INSERT statement uses "HONOR" with double quotes, while other string
literals are single-quoted. If interpreted as an identifier (common SQL
behavior), this example may fail; prefer single quotes for the string literal.
```suggestion
(100123, 'order', '2022-05-14 10:04:00', 'HONOR', 4),
```
##########
ja-source/docusaurus-plugin-content-docs/version-4.x/sql-manual/sql-functions/aggregate-functions/window-funnel.md:
##########
@@ -179,8 +179,8 @@ INSERT INTO
VALUES
(100123, 'login', '2022-05-14 10:01:00', 'HONOR', 1),
(100123, 'visit', '2022-05-14 10:02:00', 'HONOR', 2),
- (100123, 'order', '2022-05-14 10:03:00', "HONOR", 4),
- (100123, 'login2', '2022-05-14 10:04:00', 'HONOR', 3),
+ (100123, 'login2', '2022-05-14 10:03:00', 'HONOR', 3),
+ (100123, 'order', '2022-05-14 10:04:00', "HONOR", 4),
Review Comment:
The INSERT statement uses "HONOR" with double quotes, while other string
literals are single-quoted. If interpreted as an identifier (common SQL
behavior), this example may fail; prefer single quotes for the string literal.
```suggestion
(100123, 'order', '2022-05-14 10:04:00', 'HONOR', 4),
```
##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/sql-manual/sql-functions/aggregate-functions/window-funnel.md:
##########
@@ -219,13 +219,13 @@ order BY
+---------+-------+
| user_id | level |
+---------+-------+
-| 100123 | 3 |
+| 100123 | 4 |
| 100125 | 3 |
| 100126 | 2 |
| 100127 | 2 |
+---------+-------+
```
-对于`uesr_id=100123`，匹配到`下单`事件后，事件链被`登录2`事件打断，所以匹配到的事件链是`登陆-访问-下单`。
+对于`uesr_id=100123`，`登录 2`不匹配漏斗中的任何 condition。从 Doris 4.1 开始，这类无关事件不会打断 `fixed`
模式下的事件链，因此最终匹配到的事件链是`登录-访问-下单-付款`。在 4.1 之前，同样的数据会在`登录 2`处中断，只返回`登录-访问`，长度为 `2`。
Review Comment:
`uesr_id` appears to be a typo; it should be `user_id` to match the column
name used in the SQL and keep the explanation consistent.
##########
versioned_docs/version-4.x/sql-manual/sql-functions/aggregate-functions/window-funnel.md:
##########
@@ -218,13 +218,13 @@ order BY
+---------+-------+
| user_id | level |
+---------+-------+
-| 100123 | 3 |
+| 100123 | 4 |
| 100125 | 3 |
| 100126 | 2 |
| 100127 | 2 |
+---------+-------+
```
-For `uesr_id=100123`, after matching the `order` event, the event chain is
interrupted by the `login2` event, so the matched event chain is
`login-visit-order`.
+For `uesr_id=100123`, `login2` does not match any condition in the funnel.
Starting from Doris 4.1, such unrelated events do not break the `fixed` chain,
so the matched event chain is `login-visit-order-payment`. In Doris versions
earlier than 4.1, the same data would stop at `login-visit` and return level
`2`.
Review Comment:
`uesr_id` appears to be a typo; it should be `user_id` to match the column
name used throughout the examples and avoid confusing readers.
##########
i18n/zh-CN/docusaurus-plugin-content-docs/version-4.x/sql-manual/sql-functions/aggregate-functions/window-funnel.md:
##########
@@ -219,13 +219,13 @@ order BY
+---------+-------+
| user_id | level |
+---------+-------+
-| 100123 | 3 |
+| 100123 | 4 |
| 100125 | 3 |
| 100126 | 2 |
| 100127 | 2 |
+---------+-------+
```
-对于`uesr_id=100123`，匹配到`下单`事件后，事件链被`登录2`事件打断，所以匹配到的事件链是`登陆-访问-下单`。
+对于`uesr_id=100123`，`登录 2`不匹配漏斗中的任何 condition。从 Doris 4.1 开始，这类无关事件不会打断 `fixed`
模式下的事件链，因此最终匹配到的事件链是`登录-访问-下单-付款`。在 4.1 之前，同样的数据会在`登录 2`处中断，只返回`登录-访问`，长度为 `2`。
Review Comment:
`uesr_id` appears to be a typo; it should be `user_id` to match the column
name used in the SQL and keep the explanation consistent.
##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/sql-manual/sql-functions/aggregate-functions/window-funnel.md:
##########
@@ -185,8 +185,8 @@ INSERT INTO
VALUES
(100123, '登录', '2022-05-14 10:01:00', 'HONOR', 1),
(100123, '访问', '2022-05-14 10:02:00', 'HONOR', 2),
- (100123, '下单', '2022-05-14 10:03:00', "HONOR", 4),
- (100123, '登录 2', '2022-05-14 10:04:00', 'HONOR', 3),
+ (100123, '登录 2', '2022-05-14 10:03:00', 'HONOR', 3),
+ (100123, '下单', '2022-05-14 10:04:00', "HONOR", 4),
Review Comment:
这里把 "HONOR" 用了双引号，但示例中其他字符串都用单引号。SQL
中双引号通常表示标识符，可能导致示例在某些模式下不可执行；建议统一用单引号表示字符串常量。
##########
i18n/zh-CN/docusaurus-plugin-content-docs/version-4.x/sql-manual/sql-functions/aggregate-functions/window-funnel.md:
##########
@@ -185,8 +185,8 @@ INSERT INTO
VALUES
(100123, '登录', '2022-05-14 10:01:00', 'HONOR', 1),
(100123, '访问', '2022-05-14 10:02:00', 'HONOR', 2),
- (100123, '下单', '2022-05-14 10:03:00', "HONOR", 4),
- (100123, '登录 2', '2022-05-14 10:04:00', 'HONOR', 3),
+ (100123, '登录 2', '2022-05-14 10:03:00', 'HONOR', 3),
+ (100123, '下单', '2022-05-14 10:04:00', "HONOR", 4),
Review Comment:
这里把 "HONOR" 用了双引号，但示例中其他字符串都用单引号。SQL
中双引号通常表示标识符，可能导致示例在某些模式下不可执行；建议统一用单引号表示字符串常量。
```suggestion
(100123, '下单', '2022-05-14 10:04:00', 'HONOR', 4),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
