github-actions[bot] commented on code in PR #61782:
URL: https://github.com/apache/doris/pull/61782#discussion_r3006016509
##########
be/src/exec/runtime_filter/runtime_filter.cpp:
##########
@@ -39,10 +39,7 @@ Status RuntimeFilter::_push_to_remote(RuntimeState* state,
const TNetworkAddress
auto merge_filter_callback =
DummyBrpcCallback<PMergeFilterResponse>::create_shared();
auto merge_filter_closure =
AutoReleaseClosure<PMergeFilterRequest,
DummyBrpcCallback<PMergeFilterResponse>>::
- create_unique(merge_filter_request, merge_filter_callback,
-
state->query_options().ignore_runtime_filter_error
- ? std::weak_ptr<QueryContext> {}
- : state->get_query_ctx_weak());
+ create_unique(merge_filter_request, merge_filter_callback);
void* data = nullptr;
Review Comment:
**Behavioral change**: Previously, this `AutoReleaseClosure` received a
`weak_ptr<QueryContext>` (when `ignore_runtime_filter_error=false`), and
`_process_if_rpc_failed()` / `_process_if_meet_error_status()` would cancel the
query on merge_filter RPC failure.
Now with the `QueryContext` removed from `AutoReleaseClosure`, this path
only logs a `WARNING` on failure -- the query is **not** cancelled. The same
applies to the coordinator-side `sync_filter_size` and `publish_filter` RPCs in
`runtime_filter_mgr.cpp`.
If this is intentional (runtime filter failures are non-fatal for
correctness), it should be documented in the PR description as a deliberate
behavioral change. If not, these paths need custom callbacks (like
`SyncSizeCallback`) that respect `ignore_runtime_filter_error` and cancel the
query when appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
