github-actions[bot] commented on code in PR #14783:
URL: https://github.com/apache/doris/pull/14783#discussion_r1038712517
##########
be/src/vec/functions/function_binary_arithmetic.h:
##########
@@ -105,9 +105,7 @@ struct BinaryOperationImplBase {
static void vector_constant(const PaddedPODArray<A>& a, B b,
PaddedPODArray<ResultType>& c) {
size_t size = a.size();
- for (size_t i = 0; i < size; ++i) {
- c[i] = Op::template apply<ResultType>(a[i], b);
- }
+ for (size_t i = 0; i < size; ++i) c[i] = Op::template
apply<ResultType>(a[i], b);
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
for (size_t i = 0; i < size; ++i) { c[i] = Op::template
apply<ResultType>(a[i], b);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
