github-actions[bot] commented on PR #61738: URL: https://github.com/apache/doris/pull/61738#issuecomment-4131420026
## Code Review: Dead Code Removal Reviewed all 92 changed files (1,781 lines deleted, 1 line added). This is a pure dead code removal PR with no behavioral changes. ### Critical Checkpoint Conclusions (Part 1.3) - **Goal**: Remove dead code from FE `analysis`, `common`, `nereids`, `planner`, and `qe` packages. **Achieved** — all 13 deleted classes and all deleted methods/fields verified as having zero remaining references in the codebase. - **Minimal and focused**: Yes — pure deletions, no logic changes. - **Concurrency**: Not applicable — no concurrency-related code added or modified. - **Lifecycle management**: Not applicable. - **Configuration items**: None added. - **Incompatible changes / storage formats**: None. Verified no `@SerializedName`, `@JsonProperty`, `Writable`, `GsonPostProcessable`, or EditLog-related code is affected by the removals. - **Parallel code paths**: Not applicable — removals only. - **Special conditional checks**: Not applicable. - **Test coverage**: No tests needed — dead code removal cannot change behavior. - **Observability**: Not applicable. - **Transaction/persistence**: Verified safe. The `needTableStable` field in `AlterTableOp` was write-only (never read). The `DistributionDesc.type` field was write-only. No persistence paths affected. - **Data writes**: Not applicable. - **FE-BE variables**: Not applicable. - **Performance**: No concerns — removing dead code marginally reduces class loading and compilation time. - **Other issues**: One observation (not a bug): `BucketSpecifyInstances` and `DefaultSpecifyInstances` were the only concrete subclasses of the abstract `NereidsSpecifyInstances`. After removal, `NereidsSpecifyInstances` has no concrete implementations. This could indicate additional dead code to clean up in a follow-up, but is not a problem for this PR. ### Verification Summary | Category | Count | Status | |----------|-------|--------| | Deleted classes | 13 | All verified dead (zero references) | | Deleted public methods | 55 | All verified dead (zero callers) | | Deleted private methods | 21 | All verified dead (zero callers) | | Deleted fields | 10 | All verified dead (write-only or unreferenced) | | Serialization safety | All fields | No persistence/serialization impact | **Result**: No issues found. Clean dead code removal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
