github-actions[bot] commented on code in PR #61512:
URL: https://github.com/apache/doris/pull/61512#discussion_r2991619124
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/ThriftHMSCachedClient.java:
##########
@@ -89,14 +91,14 @@ public class ThriftHMSCachedClient implements
HMSCachedClient {
// -1 means no limit on the partitions returned.
private static final short MAX_LIST_PARTITION_NUM =
Config.max_hive_list_partition_num;
- private Queue<ThriftHMSClient> clientPool = new LinkedList<>();
+ private final Queue<ThriftHMSClient> clientPool = new LinkedList<>();
private boolean isClosed = false;
Review Comment:
Nit: Good fix — the original `> poolSize` allowed the pool to grow to
`poolSize + 1` entries. The `>= poolSize` correction properly caps it at
exactly `poolSize`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
