github-actions[bot] commented on code in PR #61326:
URL: https://github.com/apache/doris/pull/61326#discussion_r2985584108
##########
be/src/util/cpu_info.h:
##########
@@ -148,6 +148,16 @@ class CpuInfo {
static std::string debug_string();
+ static long get_cache_size(CacheLevel level) {
+ DCHECK(initialized_);
+ return cache_sizes_[level];
+ }
+
+ static long get_cache_line_size(CacheLevel level) {
+ DCHECK(initialized_);
+ return cache_line_sizes_[level];
+ }
+
/// A utility class for temporarily disabling CPU features. Usage:
Review Comment:
These accessors are added but never used anywhere in this PR. The PR title
claims "Dynamic streaming hash table min reduction based on CPU cache" but the
streaming aggregation code still uses hardcoded constants from
`streaming_agg_min_reduction.h`. Either this PR is incomplete (missing the
dynamic calculation logic that would use these accessors), or the
title/description needs to be corrected to reflect that this is just
infrastructure/refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
