Copilot commented on code in PR #61701:
URL: https://github.com/apache/doris/pull/61701#discussion_r2985580416
##########
be/src/storage/tablet/tablet_meta.cpp:
##########
@@ -354,6 +354,7 @@ TabletMeta::TabletMeta(int64_t table_id, int64_t
partition_id, int64_t tablet_id
schema->set_disable_auto_compaction(tablet_schema.disable_auto_compaction);
}
+ // Deprecated legacy flatten-nested switch. Distinct from
variant_enable_nested_group.
if (tablet_schema.__isset.variant_enable_flatten_nested) {
schema->set_enable_variant_flatten_nested(tablet_schema.variant_enable_flatten_nested);
}
Review Comment:
`TabletSchema` no longer defines `set_enable_variant_flatten_nested()` (it
was renamed to `set_deprecated_variant_flatten_nested()`), so this call will
fail to compile. Update the setter call here to the new API (or reintroduce a
compatibility wrapper if needed).
##########
be/src/util/json/json_parser.cpp:
##########
@@ -206,7 +206,7 @@ void JSONDataParser<ParserImpl>::traverseArrayElement(const
Element& element,
element_ctx.has_nested_in_flatten = ctx.has_nested_in_flatten;
element_ctx.is_top_array = ctx.is_top_array;
traverse(element, element_ctx);
- auto& [_, paths, values, flatten_nested, __, is_top_array] = element_ctx;
+ auto& [_, paths, values, deprecated_flatten_nested, __, is_top_array] =
element_ctx;
Review Comment:
The structured binding introduces several unused variables (`_`,
`deprecated_flatten_nested`, `__`) which will trigger `-Wunused-variable` and
fail the BE build because `be/CMakeLists.txt` enables `-Werror`. Avoid binding
unused fields (access `element_ctx.paths`/`values` directly), or mark unused
bindings with `[[maybe_unused]]`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
