BiteTheDDDDt opened a new pull request, #61693: URL: https://github.com/apache/doris/pull/61693
This pull request improves the accuracy and clarity of scanner timing and profiling in the `ScannerScheduler` implementation. The main changes clarify the order and logic for updating and recording timing counters, ensuring that CPU and wait times are measured more precisely during scanner execution and cleanup. **Enhancements to scanner timing and profiling:** * Added detailed comments explaining the correct order for setting and getting timing counters (`update_wait_worker_timer`, `start_scan_cpu_timer`, `update_scan_cpu_timer`, `start_wait_worker_timer`) to ensure accurate measurement of scanner CPU and wait times. * Refactored the `Defer` cleanup logic to only start the wait worker timer if the scanner has not failed and has not reached the end-of-stream, preventing redundant or incorrect counter updates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
