seawinde commented on PR #61176: URL: https://github.com/apache/doris/pull/61176#issuecomment-4116737991
The logic looks reasonable to me, but this PR doesn't include any tests. Could you add: A regression test for the filter-edge elimination fix — the repro SQL from the PR description (t1 LEFT JOIN t2 ON t1.id = t2.id AND t2.id = 1 with a UNIQUE constraint on t2) would be a good start. Verify that explain SELECT id, name FROM t1 shows the MV being used after rewrite. A regression test for constraint-change cache invalidation — something like: create an MTMV with a join, ADD CONSTRAINT on the joined table, then verify the rewrite result changes without needing to manually refresh the MV. Similarly test DROP CONSTRAINT to ensure the rewrite correctly stops eliminating the join. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
