shuke987 opened a new pull request, #61558: URL: https://github.com/apache/doris/pull/61558
## Summary - Remove unused `#include "runtime/descriptors.h"` from 2 header files (`tablet_schema.h`, `serialize.h`) that do not use any descriptor types - Replace the include with forward declarations in 7 header files that only use descriptor types as pointers/references: `vdata_gen_function_inf.h`, `scan_operator.h`, `vtablet_block_convertor.h`, `max_compute_jni_reader.h`, `wal_reader.h`, `segment.h` - Add forward declaration for `SlotDescriptor` in `generic_reader.h` which uses the type as pointer parameter - Move the full `#include "runtime/descriptors.h"` to corresponding `.cpp` files (`scan_operator.cpp`, `wal_reader.cpp`, `segment.cpp`) where the complete type definition is needed This reduces the include fan-out of `runtime/descriptors.h` (535 lines) across the codebase, improving incremental build times when `descriptors.h` is modified. ### Files changed | Header | Action | |--------|--------| | `olap/tablet_schema.h` | Remove include (unused) | | `vec/jsonb/serialize.h` | Remove include (already has forward decl) | | `pipeline/common/data_gen_functions/vdata_gen_function_inf.h` | Forward-declare `TupleDescriptor` | | `pipeline/exec/scan_operator.h` | Forward-declare `DescriptorTbl`, `SlotDescriptor`, `TupleDescriptor` | | `vec/sink/vtablet_block_convertor.h` | Forward-declare `TupleDescriptor` | | `vec/exec/format/generic_reader.h` | Forward-declare `SlotDescriptor` | | `vec/exec/format/table/max_compute_jni_reader.h` | Forward-declare `MaxComputeTableDescriptor` | | `vec/exec/format/wal/wal_reader.h` | Forward-declare `TupleDescriptor` | | `olap/rowset/segment_v2/segment.h` | Forward-declare `SlotDescriptor` | ## Test plan - [ ] Verify full build passes (`run buildall`) - [ ] No new include cycles introduced 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
