Gabriel39 commented on code in PR #14664:
URL: https://github.com/apache/doris/pull/14664#discussion_r1034703223
##########
be/src/olap/column_predicate.h:
##########
@@ -166,13 +166,13 @@ class ColumnPredicate {
}
uint32_t column_id() const { return _column_id; }
- virtual std::string debug_string() {
+ virtual std::string debug_string() const {
return _debug_string() + ", column_id=" + std::to_string(_column_id) +
Review Comment:
I think `column_id` doesn't make sense for users. It's better to get the
real column name according to `SegmentIterator` 's variable `_schema`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
