mrhhsg commented on code in PR #14616:
URL: https://github.com/apache/doris/pull/14616#discussion_r1034194925
##########
be/src/vec/functions/function_convert_tz.h:
##########
@@ -161,13 +180,16 @@ class FunctionConvertTZ : public IFunction {
assert_cast<const
ColumnString*>(argument_columns[2].get()),
assert_cast<ColumnDateTimeV2*>(result_column.get()),
assert_cast<ColumnUInt8*>(result_null_map_column.get())->get_data(),
- input_rows_count);
+ input_rows_count, _time_zone_cache);
block.get_by_position(result).column = ColumnNullable::create(
std::move(result_column),
std::move(result_null_map_column));
}
return Status::OK();
}
+
+private:
+ std::map<StringRef, cctz::time_zone> _time_zone_cache;
Review Comment:
After checking again, the function was not separate for each thread.
I will put the cache map into function state of FunctionContext.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
