floation-cutie commented on code in PR #60892:
URL: https://github.com/apache/doris/pull/60892#discussion_r2894942144
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/scalar/SplitByString.java:
##########
@@ -60,10 +71,20 @@ private SplitByString(ScalarFunctionParams functionParams) {
*/
@Override
public SplitByString withChildren(List<Expression> children) {
- Preconditions.checkArgument(children.size() == 2);
+ Preconditions.checkArgument(children.size() == 2 || children.size() ==
3);
return new SplitByString(getFunctionParams(children));
}
+ @Override
+ public void checkLegalityBeforeTypeCoercion() {
Review Comment:
Done. Added checkLegalityAfterRewrite() following the same pattern as Sha2.
checkLegalityBeforeTypeCoercion() now delegates to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
