[GitHub] [doris] Gabriel39 commented on a diff in pull request #14598: [fix](JdbcExecutor) fix that JdbcExecutor did not load the class jar

[GitBox]

Gabriel39 commented on code in PR #14598:
URL: https://github.com/apache/doris/pull/14598#discussion_r1032259554


##########
fe/java-udf/src/main/java/org/apache/doris/udf/JdbcExecutor.java:
##########
@@ -52,6 +52,7 @@ public class JdbcExecutor {
     private ResultSetMetaData resultSetMetaData = null;
     // Use HikariDataSource to help us manage the JDBC connections.
     private HikariDataSource dataSource = null;
+    private ClassLoader classLoader = null;

Review Comment:
   Declare this variable in `init` mothod



##########
fe/java-udf/src/main/java/org/apache/doris/udf/UdfUtils.java:
##########
@@ -214,7 +213,7 @@ public static void copyMemory(
     }
 
     public static URLClassLoader getClassLoader(String jarPath, ClassLoader 
parent) throws MalformedURLException {
-        URL url = new File(jarPath).toURI().toURL();
+        URL url = new URL(jarPath);

Review Comment:
   Add a rule to check whether this jar exists



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org